Add simple test for evaluate #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/test-evaluate
branch
3 times, most recently
from
7424bc0
to
a01bbb4
Compare
ml-evs
force-pushed
the
ml-evs/test-evaluate
branch
from
a01bbb4
to
351eb70
Compare
ml-evs
force-pushed
the
ml-evs/test-evaluate
branch
from
351eb70
to
beb29dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #210, simply run the evaluate function and check that it is finite.
This test should fail until I rebase with the latest changes from #210; I think sadly our former tests for this were too slow for the CI and were disabled (maybe we should re-enable them again now that we are making some more changes).