-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug verify #80
Bug verify #80
Conversation
Kudos, SonarCloud Quality Gate passed! |
} else { | ||
// no returnValueSupplier -> we have to log the invocations for recordings | ||
final Object returnValue = invocation.proceed(); | ||
final List<Object> arguments = Arrays.asList(invocation.getArguments()); | ||
|
||
ExecutionManager.record(sampleDefinition, new MethodCall(returnValue, arguments)); | ||
return returnValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move record and return value outside the if
|
||
ExecutionManager.record(sampleDefinition, new MethodCall(returnValue, Arrays.asList(joinPoint.getArgs()))); | ||
|
||
return returnValue; | ||
} else { | ||
// no returnValueSupplier -> we have to log the invocations for recordings | ||
final Object returnValue = joinPoint.proceed(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move record and return returnValue outside the if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions
#76