Polymorphic persistence Issue #70 #83
Conversation
# Conflicts: # deepsampler-provider/src/testFixtures/java/de/ppi/deepsampler/provider/common/SamplerAspectTest.java # deepsampler-provider/src/testFixtures/java/de/ppi/deepsampler/provider/common/TestService.java
JanSchankin
changed the title
|
|
||
| // Realen Typen Dog | ||
| // Declared Type Animal | ||
| // Generic null |
There was a problem hiding this comment.
comments seem to be scratches, they should be removed
| } | ||
| } else { | ||
| returnClass= sampledMethod.getMethod().getReturnType(); | ||
| } |
There was a problem hiding this comment.
The code shuld be reformatted. Missing spaces after = and too long lines.
Usage of string.format() with placeholders instead of string-concatenation using + would also be better. PersistenceException has a convenient constructor for that.
There was a problem hiding this comment.
I am unsure what do you mean by, that there is a convinient constructor for a concatination in the constuctor of the exception.
...er-persistence/src/main/java/de/ppi/deepsampler/persistence/api/PersistentSampleManager.java
Outdated
Show resolved
Hide resolved
|
|
||
| import java.util.Map; | ||
|
|
||
| public class PolymorphicPersistentBean extends DefaultPersistentBean{ |
There was a problem hiding this comment.
Some javaodc is needed to explain what this is and why we have built it
| import java.lang.reflect.ParameterizedType; | ||
| import java.lang.reflect.Type; | ||
|
|
||
| public class BeanConversion { |
There was a problem hiding this comment.
this class shouldn't be in this branch
| @Test | ||
| public void polymorphicSamplesCanBeRecordedAndLoaded() throws IOException { | ||
| // Ensure, that no Samples from previous tests exists... | ||
| Sampler.clear(); |
There was a problem hiding this comment.
This aleady done by @beforeeach
| final PersistentSampleManager source = PersistentSampler.source(JsonSourceManager.builder().buildWithFile(pathToFile)); | ||
| source.record(); | ||
|
|
||
| // Reset SampleRepository to ensure that only deserialized samples will be used in the next steps... |
There was a problem hiding this comment.
This is copied code. there is a method for that:
| @@ -544,4 +544,40 @@ private PersistentSampleManager save(Path pathToFile) { | |||
| return source; | |||
| } | |||
|
|
|||
| @Test | |||
| public void polymorphicSamplesCanBeRecordedAndLoaded() throws IOException { | |||
There was a problem hiding this comment.
The extension TempJsonFile injects a Path to a tmp file and deletes that file after the test has run. You can add a parameter Path tempFile to the method to get access to the tmp file.
There is also a helper-method that uses the tmpFile to create a PersistnetSampleManager:
…rphic-feature # Conflicts: # README.md # deepsampler-persistence/src/main/java/de/ppi/deepsampler/persistence/api/PersistentSampleManager.java # deepsampler-provider/src/testFixtures/java/de/ppi/deepsampler/provider/common/Cat.java # deepsampler-provider/src/testFixtures/java/de/ppi/deepsampler/provider/common/PersistentSamplerAspectTest.java # deepsampler-provider/src/testFixtures/java/de/ppi/deepsampler/provider/common/TestService.java
JanSchankin
changed the title
…ension. The class is not used yet, and it messes up the test coverage
…ension. The class is not used yet, and it messes up the test coverage
| return (T) originalBean; | ||
| } | ||
|
|
||
| /** | ||
| * Todo |
| import java.lang.reflect.ParameterizedType; | ||
| import java.lang.reflect.Type; | ||
|
|
||
| public class BeanConversion { |
|
|
||
| import java.util.Map; | ||
|
|
||
| public class PolymorphicPersistentBean extends DefaultPersistentBean{ |
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.