🌠Feature configurable json path #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…older cannot be seen on the classpath
chb-ppi
reviewed
Nov 29, 2021
| */ | ||
| String file() default ""; | ||
| String fileName() default AnnotationConstants.DEFAULT_VALUE_MUST_BE_CALCULATED; |
There was a problem hiding this comment.
packagename and filename are difficult to understand. They provide four option to configure. If someone wishes to use own filenames, they must provide a full qualified filename.
There was a problem hiding this comment.
We now have only one property which defines the complete file name including the path.
|
Kudos, SonarCloud Quality Gate passed! |
JanSchankin
changed the title
chb-ppi
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.