Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Add some optional configuration settings for isso. #225

Merged
merged 4 commits into from
Jun 20, 2018

Conversation

theKidOfArcrania
Copy link
Contributor

Better configurations for isso comments.

I'm not sure if there is any coding conventions/style/testing that needs to be done before merging. If there is, let me know and I will fix it.

* This adds support for some standard isso options. (They are optional, and will
  be omitted if not provided in the respective config file).
* Special "site" property to set the location of the isso server.
* Competely backwards compatible (if user provides a string instead of
  individual properties for isso comments).
@ppoffice
Copy link
Owner

@theKidOfArcrania Thank you for your contribution. I think you need to clean up and format the statcounter code. Also, please be careful inserting elements after the footer section because if you do that, the element will be outside of the layout.

@theKidOfArcrania
Copy link
Contributor Author

Heh.. I was in a rush to commit statcounter code (and that was the exact code that statcounter gave me). Also, actually I think it was originally installed in the head, not even after the footer area (was not aware of the file structure initially). I will fix it very soon.

* Add an "on" setting for isso comments. (For backwards compatibility, a string
  can also be supplied to isso, and it would give the same effect as setting
  "on" to true and "site" to the string). TODO: maybe remove this in a future
  release, or deprecate the string version?
* Format the statcounter code, and place it within the header, under the credits
  bar. (Maybe is there a better way to place it?)
* Add the example configuration values to the _config.yml.example file.
* Fix some syntax errors.
* Add a warning for supplying a string to "comment.isso"
* Add a setting to add a link to public stats in statcounter
* Fix some minor formattings.
@theKidOfArcrania
Copy link
Contributor Author

Code should be fixed up, although I'm not entirely sure if emitting a deprecation warning (when a string value is supplied to comment.isso) using console.warn is the best approach. Oh well, if you have any better suggestions let me know.

@ppoffice ppoffice merged commit 4a3365b into ppoffice:master Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants