Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using OpenTK's GameWindow #11

Closed
peppy opened this issue Aug 31, 2016 · 4 comments
Closed

Try using OpenTK's GameWindow #11

peppy opened this issue Aug 31, 2016 · 4 comments
Labels

Comments

@peppy
Copy link
Member

peppy commented Aug 31, 2016

Avoid our custom form stack.

Things to note:

  • We need to make sure we can still make angle work.
  • We need to make sure we can get exclusive full-screen (GLControl likely needs to be derived from Form).
  • Switch to OpenTK based input handlers and remove the form counterparts (these are already implemented but not used).
  • Figure a way to handle input for things like TextBoxes.
  • Figure out what we can do about IME.
@peppy peppy added the proposal label Aug 31, 2016
@ddevault
Copy link
Contributor

ddevault commented Sep 5, 2016

Figure out what we can do about IME.

We can just implement it ourselves, which is what we'd probably need to do for the Linux port anyway. I have a friend who implemented his own IME in a tty based on Anthy. A couple of DLLMaps and we can pass in keystrokes and get back UTF-8 suggestions.

@wobbol wobbol mentioned this issue Sep 15, 2016
@Tom94
Copy link
Collaborator

Tom94 commented Oct 8, 2016

Exclusive fullscreen is not just a windows thing. The important part is that osu! doesn't need to go through a compositor, but rather goes directly to the video buffer.

@peppy
Copy link
Member Author

peppy commented Oct 8, 2016

I think it's definitely fine to ignore angle support when testing things like GameWindow (and making everything else work first), after which we can figure out how to tackle the angle issue.

Exclusive fullscreen and text input is important though.

So going down your list:

  1. yes, just keep in mind that it is imperative to have in the end.
  2. no (see @Tom94's answer)
  3. they are already being used in LinuxGameHost.
  4. look at the textbox code, specifically CreateTextInput()
  5. it's of utmost importance. adding "for now" is not really a thing; if you don't consider these things from the start and figure out after you've done everything that it's not feasible, that's a lot of wasted time, right?
  6. no one said anything about switching to monogame? we need to examine all possible paths and choose the best.

@peppy
Copy link
Member Author

peppy commented Oct 12, 2016

WIP @ #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants