Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextBox should only handle keyboard input when focused #1471

Merged
merged 2 commits into from Mar 22, 2018
Merged

TextBox should only handle keyboard input when focused #1471

merged 2 commits into from Mar 22, 2018

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Mar 19, 2018 •
edited

Closes ppy/osu#2234.
Closes ppy/osu#2237.

@peppy peppy mentioned this pull request Mar 19, 2018
Closed
@smoogipoo
Copy link
Contributor

smoogipoo commented Mar 20, 2018 •
edited

One issue with this - SongSelect's textbox is not focused by default. Probably is a separate issue altogether though..

smoogipoo
smoogipoo requested changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented, doesn't happen on master.

@peppy peppy mentioned this pull request Mar 22, 2018
Merged
1 task
@peppy
Copy link
Sponsor Member Author

peppy commented Mar 22, 2018

Fixed regression at osu!'s end.

@smoogipoo smoogipoo merged commit 241133f into ppy:master Mar 22, 2018
@peppy peppy deleted the textbox-handle-on-focus branch April 18, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peppy @smoogipoo