Fix emphasised markdown text not flowing correctly #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
approved these changes
Jan 21, 2023
Comment on lines
-203
to
-210
| protected virtual SpriteText CreateEmphasisedSpriteText(bool bold, bool italic) | ||
| { | ||
| var textDrawable = CreateSpriteText(); | ||
|
|
||
| textDrawable.Font = textDrawable.Font.With(weight: bold ? "Bold" : null, italics: italic); | ||
|
|
||
| return textDrawable; | ||
| } |
There was a problem hiding this comment.
I would've kept this method and used AddPart(CreateChunkFor(text, true, CreateEmphasisedSpriteText)) to avoid breaking changes, but it's not that bad to consider doing so.
There was a problem hiding this comment.
gonna request one more opinion from @ppy/team-client on whether it's fine to break this before I merge, we can avoid it but I feel the new method makes more sense.
smoogipoo
approved these changes
Jan 24, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
