Make TooltipContainer and ContextMenuContainer only consider children #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TooltipContainer will now do as its name implies: Enable tooltips for all its children, instead of for all its siblings in the draw graph.
Changing the sizing of the TooltipContainer could cause exceptions, nested TooltipContainers were not handled correctly and some drawables were considered that were not children of the TooltipContainer.
Tom94
reviewed
Jul 6, 2017
| content.AutoSizeAxes = Axes.None; | ||
|
|
||
| // in addition to using this.RelativeSizeAxes, sets RelativeSizeAxes on every axis that is neither relative size nor auto size | ||
| content.RelativeSizeAxes = RelativeSizeAxes | (Axes.Both & ~(RelativeSizeAxes | AutoSizeAxes)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Jul 6, 2017
| @@ -133,6 +157,8 @@ private void hideTooltip() | |||
| currentlyDisplayed = null; | |||
| } | |||
|
|
|||
| private readonly HashSet<Drawable> pathDrawables = new HashSet<Drawable>(); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Jul 6, 2017
| @@ -133,6 +157,8 @@ private void hideTooltip() | |||
| currentlyDisplayed = null; | |||
| } | |||
|
|
|||
| private readonly HashSet<Drawable> pathDrawables = new HashSet<Drawable>(); | |||
| private readonly HashSet<Drawable> nestedPathDrawables = new HashSet<Drawable>(); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Jul 6, 2017
|
|
||
| tooltipTarget = candidate as IHasTooltip; | ||
| if (tooltipTarget != null) | ||
| break; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Jul 6, 2017
| pathDrawables.Add(candidate); | ||
|
|
||
| var nestedTtc = candidate as TooltipContainer; | ||
| if (nestedTtc != null || nestedPathDrawables.Contains((Drawable)candidate.Parent)) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Jul 6, 2017
| IHasTooltip tooltipTarget = null; | ||
| foreach (var candidate in targetCandidates) | ||
| { | ||
| if (!pathDrawables.Contains((Drawable)candidate.Parent)) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Jul 6, 2017
| if (nestedTtc != null || nestedPathDrawables.Contains((Drawable)candidate.Parent)) | ||
| { | ||
| nestedPathDrawables.Add(nestedTtc ?? candidate); | ||
| continue; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Jul 6, 2017
| var nestedTtc = candidate as TooltipContainer; | ||
| if (nestedTtc != null || nestedPathDrawables.Contains((Drawable)candidate.Parent)) | ||
| { | ||
| nestedPathDrawables.Add(nestedTtc ?? candidate); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This default is a relic of the previous behavior of TooltipContainer. With the new behavior of considering only children, this is no longer needed.
…fault0/ttc-api-change
Tom94
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the TooltipContainer API to be more reasonable:
Instead of adding the ability for its siblings and parents to have tooltips, the TooltipContainer now enables tooltips for all its children.