Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/v2/comments's commentable_meta array always holds a Deleted Item #11077

Closed
TTTaevas opened this issue Mar 9, 2024 · 1 comment
Closed

api/v2/comments's commentable_meta array always holds a Deleted Item #11077

TTTaevas opened this issue Mar 9, 2024 · 1 comment

Comments

@TTTaevas
Copy link
Contributor

TTTaevas commented Mar 9, 2024

I guess it's kinda minor, but no matter the parameters used when getting /comments, there will always be a Deleted Item at the end of the commentable_meta array
While Deleted Items have been documented since #9936, the issue is that there's always one Deleted Item, even if it presumably makes no sense for one to be there
@nanaya
Copy link
Collaborator

nanaya commented Mar 11, 2024

Feel free to make a pr to conditionally remove it but otherwise I don't think it's a problem. The array is for lookup anyway.

@nanaya nanaya closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nanaya @TTTaevas