Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent activity's first osu!supporter purchase not showing correctly #3862

Closed
Joehuu opened this issue Nov 7, 2018 · 1 comment · Fixed by #3903
Closed

Recent activity's first osu!supporter purchase not showing correctly #3862

Joehuu opened this issue Nov 7, 2018 · 1 comment · Fixed by #3903
Assignees
@notbakaneko
Labels
area:user-profile type:localisation
Milestone
Candidate Issues

Comments

@Joehuu
Copy link
Member

Joehuu commented Nov 7, 2018

Recently bought osu!supporter for the first time, and it doesn't show the string linked below.

https://github.com/ppy/osu-web/blob/master/resources/lang/en/events.php#L33

Profile: https://osu.ppy.sh/users/8549835
@peppy peppy added this to the Candidate Issues milestone Nov 7, 2018
@nanaya
Copy link
Collaborator

nanaya commented Nov 15, 2018

Probably because this check is run a bit too late after the tag is applied.

osu-web/app/Libraries/Fulfillments/SupporterTagFulfillment.php

Line 97 in ef89648

$donor->hasSupported() ? 'userSupportAgain' : 'userSupportFirst',

@notbakaneko notbakaneko mentioned this issue Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notbakaneko notbakaneko

Labels
area:user-profile type:localisation
Projects
None yet
Milestone
Candidate Issues
Development

Successfully merging a pull request may close this issue.

Fix first time donation messages notbakaneko/osu-web
4 participants
@peppy @nanaya @notbakaneko @Joehuu