Fix elements in post preview being uninteractable #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2333. Not sure if it should be this way, but it should work.
|
It was originally because some elements aren't generated with correct stuff (thread link for example). Probably can be removed if that link is replaced with dummy link and remove all overlay related things as well. |
nanaya
reviewed
Feb 9, 2018
| @@ -43,7 +43,7 @@ class="forum-post__stripe" | |||
|
|
|||
| <div class="forum-post__body"> | |||
| <div class="forum-post__content forum-post__content--header"> | |||
| <a class="js-post-url link link--gray" href="{{ route('forum.posts.show', $post->post_id) }}"> | |||
| <a class="js-post-url link link--gray" href="{{ $options['preview'] ? '#' : route('forum.posts.show', $post->post_id) }}"> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
nanaya
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2333.
Not sure if it should be this way, but it should work.