New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counting per-mode open issues #2679

Merged
merged 2 commits into from Mar 15, 2018

Conversation

3 participants
@nanaya
Collaborator

nanaya commented Mar 12, 2018

Fixes #2671.

@notbakaneko notbakaneko self-requested a review Mar 15, 2018

if !d.beatmap_id? || !@beatmaps()[d.beatmap_id]?.deleted_at?
beatmap = @beatmaps()[d.beatmap_id]

if !d.beatmap_id? || (beatmap? && !beatmap.deleted_at?)

This comment has been minimized.

@notbakaneko

notbakaneko Mar 15, 2018

Contributor

what's !d.beatmap_id? for?

This comment has been minimized.

@nanaya

nanaya Mar 15, 2018

Collaborator

discussion on general all.

@notbakaneko notbakaneko merged commit 695bc34 into ppy:master Mar 15, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nanaya nanaya deleted the nanaya:open_issues_counter branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment