New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook for GitHub pull request merges #3286

Merged
merged 3 commits into from Jun 1, 2018

Conversation

2 participants
@nanaya
Collaborator

nanaya commented May 30, 2018

No frontend update yet. All merges will appear in main changelog page. For builds, it'll only show title with link to pull request.

Admin frontend also not happening yet because I ended up complicating it ┐(' ヮ' )┌

Setup:

  • env file:
    • CHANGELOG_GITHUB_TOKEN, generate with any password generator or whatever
  • github webhook:
    • webhook url: https://<domain>/home/changelog/github
    • event type: pull requests (or all)
    • secret: value of CHANGELOG_GITHUB_TOKEN

Showing in build, table build_changelog_entry:

  • build_id: build_id of the build in osu_builds
  • changelog_entry_id: id of the changelog entry in changelog_entries

Stream for web (new): call it web in streams table in osu_updates database for purple color outline. Don't forget to update UPDATE_STREAMS accordingly.

In github_users, set user_id to link user to osu! profile instead of github. User can be preemptively added by setting either user_id (osu! user id) or username (github username) or both.

@peppy peppy added this to the June 2018 milestone May 31, 2018

@peppy peppy self-assigned this May 31, 2018

@peppy

peppy approved these changes Jun 1, 2018

@peppy peppy merged commit 41f3f8e into ppy:master Jun 1, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment