New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Osu Mania Circle Skins Hold Note broke after "the basic support for stupidly long hold note skin textures change" in lazer #22578

Closed

RedstonePixels opened this issue Feb 9, 2023 · 5 comments

RedstonePixels commented Feb 9, 2023

Type

Cosmetic

Bug description

The Circle skins for osu mania has a pointy end at the end of the hold note instead of being circular.

Here's the two skins i use:
https://cdn.discordapp.com/attachments/535806778580140067/1073257552441262140/Plutes_2022_Lanecover_Plutes_2022_Lanecover_4k_Finn_orbs__5-7k_Plutes_1_4k_Finn_orbs__5-7k_Plutes.osk
https://cdn.discordapp.com/attachments/535806778580140067/1073257552755818707/Eliminate294_s_Mania_Skin_prank855_and_Myuka_-_IceTea_Edits.osk

Screenshots or videos

Version

2023.207.0

Logs

.

Contributor

Bruno5430 commented Feb 9, 2023

Did the hold notes work in the game before #22389 ?
Both of the skins you attached uses "Stupidly-long" textures for the hold notes (20.000px).
The PR said that it is, in fact, basic support for them (a 40.000px long texture was used for reference).
There's still skins without extremely long textures that were affected by the update, one of them was my personal skin (tracked in #22572)

Contributor

Bruno5430 commented Feb 9, 2023 •

edited

Loading

I tested the skins and they didn't work before the update
Short hold notes don't look that bad, but very long hold notes are just ugly

Version 2023.207.0	Version 2023.123.0

Edit: Beatmap: Nishizawa Shiena - FUBUKI

Author

RedstonePixels commented Feb 9, 2023

hmmm maybe it broke because i exported them. let me send you the original skin files. https://cdn.discordapp.com/attachments/765624183324540937/1073333654597672970/Eliminates_Mania_Skin_28.02.2022.osk
https://cdn.discordapp.com/attachments/765624183324540937/1073333655147122740/Plutes_2022_Lanecover.osk

Author

RedstonePixels commented Feb 9, 2023 •

edited

Loading

ok i managed to downgrade and this is what they used to look like

Member

peppy commented Feb 10, 2023

Duplicate of #22572

peppy marked this as a duplicate of #22572

peppy closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment