Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken font/sprite rendering on OpenGL (Veldrid) #23491

Closed
X9VoiD opened this issue May 11, 2023 · 13 comments · Fixed by ppy/osu-framework#5787
Closed

Broken font/sprite rendering on OpenGL (Veldrid) #23491

X9VoiD opened this issue May 11, 2023 · 13 comments · Fixed by ppy/osu-framework#5787

Comments

@X9VoiD
Copy link

X9VoiD commented May 11, 2023

Type

Cosmetic

Bug description

When using OpenGL (Veldrid), some letters and textures/sprites are completely missing. The missing letters/sprites changes every reboot of the game.

This issue itself is 100% reproducible on my machine with the following specs:

CPU: Intel i5-3230M
GPU: Intel HD 4000
OS: Windows 11

Screenshots or videos

osu_2023-05-12_03-49-20
osu_2023-05-12_03-49-37

In this gameplay screenshot it might not be obvious at first but the hitcircle is missing its texture:
osu_2023-05-12_03-50-09

Should be something like:
osu_2023-05-12_04-03-21


Regression?

Works on 2023.419.0:
image

Also works on 2023.403.1:
image

Version

2023.511.0

Logs

database.log
input.log
network.log
performance.log
runtime.log
updater.log

@bdach
Copy link
Collaborator

bdach commented May 11, 2023

Would you mind attaching a screenshot of the "Textures" debug window (press ctrl-f3 to show)?

@X9VoiD
Copy link
Author

X9VoiD commented May 11, 2023

image
image

@X9VoiD
Copy link
Author

X9VoiD commented May 11, 2023

I'm not sure if it helps, but there's a high chance of some letters and something in gameplay going missing, but it's rare for images to go missing if not at all.

@peppy
Copy link
Member

peppy commented May 12, 2023

Last time this happened I believe it was due to incorrect threading logic surrounding the texture upload process, but we had this fixed a long time ago..

@bdach
Copy link
Collaborator

bdach commented May 13, 2023

@X9VoiD would you be able to give https://github.com/ppy/osu-framework/compare/master...bdach:osu-framework:crapshoot?expand=1 a test and see if it fixes the issue?

@bdach
Copy link
Collaborator

bdach commented May 13, 2023

I'm pretty sure the above branch should do the trick because I accidentally reproduced this since, on the framework side.

@X9VoiD
Copy link
Author

X9VoiD commented May 13, 2023

This is what I've done so far:

  • I've checked out the branch.
  • Run osu/UseLocalFramework.ps1
  • dotnet run --project osu.Desktop

That failed so I tried running dotnet restore, it complained something about android workload. dotnet workload restore also didn't work as that throwed an InvalidProjectFileException.

So right now I'm currently running dotnet workload install android in hopes of resolving the build errors. Will report back soon.

@bdach
Copy link
Collaborator

bdach commented May 13, 2023

Very weird. Desktop project should not require android workloads to run. You should run restore only for the desktop project (dotnet restore osu.Desktop).

@X9VoiD
Copy link
Author

X9VoiD commented May 13, 2023

Ah, though now I'm getting hit by NU1202 error with dotnet restore osu.Desktop.

C:\Users\oscar\projects\osu-framework\osu.Framework\osu.Framework.csproj : error NU1202: Package Microsoft.Diagnostics.
NETCore.Client 0.2.61701 is not compatible with net6.0 (.NETCoreApp,Version=v6.0). Package Microsoft.Diagnostics.NETCor
e.Client 0.2.61701 does not support any target frameworks. [C:\Users\oscar\projects\osu\osu.Desktop\osu.Desktop.csproj]
C:\Users\oscar\projects\osu-framework\osu.Framework\osu.Framework.csproj : error NU1202: Package System.AppContext 4.1.
0 is not compatible with net6.0 (.NETCoreApp,Version=v6.0).

@bdach
Copy link
Collaborator

bdach commented May 13, 2023

I've... literally never seen that before.

Maybe try restoring framework separately first then. (dotnet restore osu.Framework from within the framework repo root)

@X9VoiD
Copy link
Author

X9VoiD commented May 13, 2023

Uhm... It still throwed the exact same error with the same exact same package.

dotnet clean didn't seem to help. Removing bin/obj also didn't help. git status shows no further modifications to both osu-framework and osu except for what osu/UseLocalFramework.ps1 did. dotnet --list-sdks shows that I do have both .NET 6.0 and 7.0 installed. Pretty sure the problem is on my side though I'm not sure what it is.

It's probably something about my NuGet cache since it insists that several packages doesn't support the target framework even though they do.

Giving dotnet nuget locals all --clear and then another dotnet restore osu.Framework a try...

@X9VoiD
Copy link
Author

X9VoiD commented May 13, 2023

Managed to fix the build issues and can confirm that the branch fixes it!

image

@bdach
Copy link
Collaborator

bdach commented May 13, 2023

Thanks a bunch for confirming 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants