Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse sensitivity is not applied to tablet input when clicking. #23839

Open
A-Duo opened this issue Jun 9, 2023 · 5 comments
Open

Mouse sensitivity is not applied to tablet input when clicking. #23839

A-Duo opened this issue Jun 9, 2023 · 5 comments
Labels
osu!framework issue Can't resolve this without changes to osu!framework. type:input

Comments

@A-Duo
Copy link

A-Duo commented Jun 9, 2023

Type

Game behaviour

Bug description

Moving the pen while it's in contact with the tablet sets the cursor to the raw tablet input without applying the sensitivity setting.

The effect for the user is that if you tap or hold with the pen then move, your cursor will snap towards or away from the center of the screen based on your sensitivity setting.
This can make selecting a song difficult because if you move your pen any amount while tapping it will be detected as a scroll and can ruin aim while playing a song if you brush your pen against your tablet.

Screenshots or videos

No response

Version

2023.605.0-lazer

Logs

As a note I don't think the logs show anything useful for this.

runtime.log
updater.log
database.log
input.log
network.log
performance.log

@peppy
Copy link
Member

peppy commented Jun 9, 2023

Keep in mind there are thousands on thousands of players using tablets without issue.

So this is likely going to be something specific to your setup. Can you elaborate more on yourconfiguration? What tablet? What OS? Can you show this happening in a video?

@peppy peppy added missing details Can't move forward without more details from the reporter type:input labels Jun 9, 2023
@A-Duo
Copy link
Author

A-Duo commented Jun 11, 2023

Sorry for not being providing enough info before.

I'm running on windows 10 using a wacom intuos medium tablet with their driver and windows ink enabled.
Shown below is the cursor snapping when tapping or holding with the pen.

osu.2023.06.11.-.07.52.32.01.mp4

I think I've found what my issue was and it seems to be an osu-framework issue instead of an osu issue.

When the pen isn't touching the tablet it's handled here: osu-framework WindowsMouseHandler
This code applies the sensitivity settings to my pen position before it is handled by the MousePositionAbsoluteInput event.

However when my pen is contacting the tablet it's treated as a touch and handled here: osu-framework InputManager
This piece of code just takes the raw position of the pen and will eventually reach the MousePositionAbsoluteInput event unchanged.

I'm not sure if there's a way to detect my touch input as tablet input since I'm not using open tablet driver.
If it was possible to detect the user was using a tablet but not the open tablet driver and then provide an option in settings to apply sensitivity to both Mouse and touch input or neither, that'd be nice.
Though I understand if that's not a thing you can detect or a priority to be added.

@peppy
Copy link
Member

peppy commented Jun 12, 2023

One possible solution is to disable touch support in osu! settings.

@Susko3
Copy link
Member

Susko3 commented Jun 12, 2023

The problem is in how SDL handles windows ink, see ppy/osu-framework#5309. The problem is that the fix is only available with SDL3 currently (no public release yet).

@A-Duo
Copy link
Author

A-Duo commented Jun 12, 2023

Yeah I guess I'll just wait until windows ink touch can be differentiated.

Sadly I can't just disable windows ink as the other thread suggests because that causes my cursor position to not update about every other second for some reason that I didn't look into. And it's not a great solution to change my tablet settings since that feature is super useful for other apps.

Disabling touch also wouldn't work since that just causes my cursor to stop moving whenever I touch my tablet since it's treated as a touch.

It's not a big deal since I can just set my sensitivity to 1.0 when I use tablet but it is somewhat annoying.

@peppy peppy added osu!framework issue Can't resolve this without changes to osu!framework. and removed missing details Can't move forward without more details from the reporter labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
osu!framework issue Can't resolve this without changes to osu!framework. type:input
Projects
None yet
Development

No branches or pull requests

3 participants