OpenUrlExternally() can crash game on broken configurations

[SheepCommander]

Type

Crash to desktop

Bug description

Consistently if I click "View in Browser" three times within a certain time frame, Osu will freeze and crash.

Waiting long enough between clicks will not cause this crash, but an impatient me accidentally discovered it anyways.

Possibly related is that my default browser is the ungoogled-chromium-windows project, specifically a Portable version if that matters.

Screenshots or videos

2023-09-01.01-02-19.mp4

Version

2023.815.0-lazer

Logs

network.log
performance.log
runtime.log
updater.log
database.log
input.log

[bdach]

Um.

2023-09-01 08:04:45 [error]: System.ComponentModel.Win32Exception (0x800401F5): An error occurred trying to start process 'https://osu.ppy.sh/beatmapsets/908#osu/7036' with working directory 'C:\Users\zachi\AppData\Local\osulazer\app-2023.815.0'. Application not found
2023-09-01 08:04:45 [error]: at System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startInfo)
2023-09-01 08:04:45 [error]: at System.Diagnostics.Process.Start()
2023-09-01 08:04:45 [error]: at System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
2023-09-01 08:04:45 [error]: at osu.Framework.Platform.DesktopGameHost.openUsingShellExecute(String path)
2023-09-01 08:04:45 [error]: at osu.Framework.Platform.DesktopGameHost.OpenUrlExternally(String url)
2023-09-01 08:04:45 [error]: at osu.Game.Graphics.UserInterface.ExternalLinkButton.OnClick(ClickEvent e)

I think this is going to be something with your machine. Misconfigured shell associations or something like that.

I guess we can try-catch to make it not-crash, but it won't work because your registry seems broken.

[ppy-sentryintegration]

Sentry issue: OSU-FHV

[SheepCommander]

Misconfigured shell and broken registry?

Damn Windows. This is a fresh install ;-;

[bdach]

Pausibly related is that my default browser is the ungoogled-chromium-windows project, specifically a Portable version if that matters.

Whatever you did there probably broke it. If it's on some drive that's not always available, this crash is gonna happen when you try to open websites via lazer when it's not - because the registry associates the handler for URLs with the portable install, so if it's not there for it to use, nothing can work sanely anymore.

[SheepCommander]

My entire computer is on a single drive, but yep def has to do with the portable install which I've deleted and re-downloaded a couple times

[peppy]

Installing any browser should fix the issue

[SheepCommander]

Oh btw it indeed does, I forgot to mention

[bdach]

Reopening so that the reliability fix is actually made.

[Seligmann]

Not sure if the answer to this is already realized or not, but is the issue that the removable media wasn't plugged in that the portable browser was on when trying to OpenUrlExternally() , or is the file association not able to be built as intended if it's on a separate (and or removable) drive from Osu?

[peppy]

The issue is that we need to not crash on a failure of this function. It just needs a try-catch.

[yesseruser]

I'd like to add the try-catch.
Could you assign me please?

[Seligmann]

Do we need to be assigned? I actually already added the try-catch and made a demo video, but when I tried to open a PR to merge my feature branch into main, I don't have permissions. From looking at other PRs, I need to fork OSU and go about things that way.

[bdach]

This issue is so simple that it should not require assignments. First PR probably wins, if it's not doing anything egregiously wrong.

[yesseruser]

^ Created a PR.
ppy/osu-framework#5989