Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improperly initialised realm after resetting storage to default location #26027

Open
ILW8 opened this issue Dec 21, 2023 · 4 comments
Open

improperly initialised realm after resetting storage to default location #26027

ILW8 opened this issue Dec 21, 2023 · 4 comments
Assignees

Comments

@ILW8
Copy link
Contributor

ILW8 commented Dec 21, 2023

Type

Game behaviour

Bug description

If osu!'s storage is set to a non-default location and that location either becomes inaccessible or gets deleted, the user is prompted with a dialog to reset to the default storage location. When the user presses the reset button, osu!'s storage is reset to its default location but legacy rulesets among other things are missing in the new realm.

Everything works again after a game restart.

Screenshots or videos

2023-12-21_23-19-05.mp4.reenc.mp4

Version

2023.1222.0

Logs

compressed-logs.zip

@ILW8
Copy link
Contributor Author

ILW8 commented Dec 21, 2023

Another thing, if the default storage path already exists and contains a valid database, clicking the reset button here will create a new database and start from fresh. I think osu! should at least try to find and use an existing database if it exists

@smoogipoo smoogipoo added the realm deals with local realm database label Dec 22, 2023
@peppy
Copy link
Member

peppy commented Jan 16, 2024

Your logs don't seem to have anything about the error you encountered. I'd expect to see at least:

if (error != OsuStorageError.None)
Logger.Log($"Custom storage location could not be used ({error}).");

They are also missing log headers.

If possible could you please provide the full logs?

among other things are missing in the new realm.

Could you please list other things?

reset button here will create a new database and start from fresh

It shouldn't, there's no logic to do that..

@peppy peppy self-assigned this Jan 16, 2024
@ILW8
Copy link
Contributor Author

ILW8 commented Jan 16, 2024

Tried again looks like logs end up in two places:

  • first part of the logs is written to the custom storage location's logs directory
  • second part of the logs (after clicking "Reset") end up written to the default storage location's logs directory.

logs_custom_location.zip
logs_default_location.zip

2024-01-16_08-59-45.mp4.reenc.mp4

Could you please list other things?

Yes, well client.realm is completely empty after resetting the storage location. Whereas deleting client.realm and starting the game populates 4 Skins (the default skins), 10 RulesetSettings, 4 Rulesets, and 261 KeyBindings

reset button here will create a new database and start from fresh

It shouldn't, there's no logic to do that..

I'm not sure what led me to this conclusion, but I'm unable to reproduce this anymore. What I do remember is that at some point, my main installation's client.realm (at default storage location) was gone and I could not find any recent backup realm file

@peppy peppy removed the realm deals with local realm database label Jan 16, 2024
@peppy
Copy link
Member

peppy commented Jan 17, 2024

Easiest solution is likely to restart the game. Probably dependent on #26558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants