Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering more than 1 slider in the editor causes heavy performance issues #28618

Closed
piee-kun opened this issue Jun 26, 2024 · 14 comments · Fixed by #28621
Closed

Rendering more than 1 slider in the editor causes heavy performance issues #28618

piee-kun opened this issue Jun 26, 2024 · 14 comments · Fixed by #28621
Assignees

Comments

@piee-kun
Copy link

piee-kun commented Jun 26, 2024

Type

Performance

Bug description

During editing, when more than one slider is being rendered (usually around 3-4 can cause massive drops), the FPS drops heavily. As far as my testing went, this does not occur with circles, and it doesn't occur in gameplay. Both Vulkan and D3D11 experience this issue, however FPS on Vulkan is less affected, as the base framerate is higher.

Screenshots or videos

4 sliders rendered
image
5 circles rendered
image

Version

2024.625.2

Logs

compressed-logs.zip

@Peter-io
Copy link

Peter-io commented Jun 26, 2024

Same here
image
vs
image

Sliders really tank performance now

@peppy
Copy link
Member

peppy commented Jun 26, 2024

This is probably going to be from UpdateState being called (and now forcefully) every frame.

@bdach I think we'll just want to change the every-frame transforms to not be transforms as I touched on in the original PR. I don't think it will be hard to convert them to raw interpolations. Will take a look tomorrow unless you want to.

@piee-kun
Copy link
Author

piee-kun commented Jul 1, 2024

unsure if it's related, but I think fix in #28621 only fixes the problem temporarily. Recently I've left my editor open for ~1hr and my performance was really bad, sub 20fps bad

@piee-kun
Copy link
Author

piee-kun commented Jul 1, 2024

i'm not able to provide screenshots, out of panic i quit the map and reopened the editor.

EDIT: provided logs
compressed-logs.zip

@peppy
Copy link
Member

peppy commented Jul 2, 2024

@piee-kun to confirm, was that one hour of the editor open without using it at all? knowing the specifics will help us reproduce the issue.

@piee-kun
Copy link
Author

piee-kun commented Jul 2, 2024

@peppy correct, i went afk for an hour to do something and the editor was open in the background, i don't think it was tabbed in

@piee-kun
Copy link
Author

piee-kun commented Jul 2, 2024

i had once again gone afk, unsure for how long, but the problem how now returned when sliders were being rendered

8mb.video-vpz-aVBZblb7.-.Trim.mp4

compressed-logs.zip

@piee-kun
Copy link
Author

piee-kun commented Jul 2, 2024

Untitled

@Peter-io
Copy link

Peter-io commented Jul 2, 2024

image

This seems to be an issue on piee video and no sliders are selected

@piee-kun
Copy link
Author

piee-kun commented Jul 2, 2024

image

This seems to be an issuie on piee video and no sliders are selected

should also mention this ms value keeps increasing over time
image

@bdach bdach reopened this Jul 2, 2024
@bdach
Copy link
Collaborator

bdach commented Jul 2, 2024

I'll recheck again to be sure but I'm 99% sure the fix mentioned above just hasn't made a release yet.

@piee-kun
Copy link
Author

piee-kun commented Jul 2, 2024

ah, sorry, you might be correct. #28592 is included in latest release and i mightve confused it with #28621

@piee-kun
Copy link
Author

piee-kun commented Jul 2, 2024

i was entirely under the impression that it was in release, my apologies.

@bdach
Copy link
Collaborator

bdach commented Jul 3, 2024

Have left the game running in background for 1 hour on master and cannot reproduce this, so I'm going to just claim that this was fixed but just hasn't made a release as per above until proven otherwise.

@bdach bdach closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants