Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance drops when adjusting difficulty settings in editor on an already populated beatmap #30112

Closed
peppy opened this issue Oct 4, 2024 · 0 comments · Fixed by #30114
Closed
Assignees
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users. type:performance

Comments

@peppy
Copy link
Sponsor Member

peppy commented Oct 4, 2024

JetBrains Rider-EAP 2024-10-04 at 09 56 08

This code should only run on mouse release, basically:

private void updateValues()
{
// for now, update these on commit rather than making BeatmapMetadata bindables.
// after switching database engines we can reconsider if switching to bindables is a good direction.
Beatmap.Difficulty.CircleSize = circleSizeSlider.Current.Value;
Beatmap.Difficulty.DrainRate = healthDrainSlider.Current.Value;
Beatmap.Difficulty.ApproachRate = approachRateSlider.Current.Value;
Beatmap.Difficulty.OverallDifficulty = overallDifficultySlider.Current.Value;
Beatmap.Difficulty.SliderMultiplier = baseVelocitySlider.Current.Value;
Beatmap.Difficulty.SliderTickRate = tickRateSlider.Current.Value;
Beatmap.BeatmapInfo.StackLeniency = stackLeniency.Current.Value;
Beatmap.UpdateAllHitObjects();
Beatmap.SaveState();
}

@peppy peppy added type:performance area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Oct 4, 2024
@bdach bdach self-assigned this Oct 4, 2024
bdach added a commit to bdach/osu-framework that referenced this issue Oct 4, 2024
For use with ppy/osu#30112. Without this, it
is difficult to tell when a slider is done applying its changes, as
there are several pathways for this (drag operation / keyboard stepping
/ direct single click).
@peppy peppy closed this as completed in 7816c41 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users. type:performance
Projects
None yet
2 participants