Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix difficulty settings sliders attempting to reprocess all hitobjects on every instantaneous change #30114

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Fix difficulty settings sliders attempting to reprocess all hitobjects on every instantaneous change #30114

merged 4 commits into from
Oct 7, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Oct 4, 2024 •
edited by peppy
Loading

@bdach
Replace FormSliderBar.Instantaneous with TransferValueOnCommit
86c3e3e 
Rather than control the propagation of the value between the slider and
the textbox, add a property that controls the propagation of the value
between the bindables inside the form control to external bindables.
This will help alleviate issues where the external bindable update
incurs overheads due to having heavy change callbacks attached.
@bdach
Only transfer difficulty slider values on commit
7816c41 
Closes ppy#30112.
@bdach bdach added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Oct 4, 2024
@peppy peppy self-requested a review October 7, 2024 05:11
peppy
peppy previously approved these changes Oct 7, 2024
View reviewed changes
@bdach bdach dismissed peppy’s stale review October 7, 2024 05:16

The merge-base changed after approval.

@peppy peppy enabled auto-merge October 7, 2024 05:16
@peppy peppy disabled auto-merge October 7, 2024 05:59
@peppy peppy merged commit af43b36 into ppy:master Oct 7, 2024
8 of 9 checks passed
@bdach bdach deleted the form-slider-bar-transfer-value-on-commit branch October 7, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:editor next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L type:performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance drops when adjusting difficulty settings in editor on an already populated beatmap
3 participants
@bdach @peppy @smoogipoo