New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Button to restore recently deleted beatmaps #1671
Conversation
…ePending" set to true.
Update: There was some misunderstanding here. I didn't notice at first, but the map(set) actually does get added again (the carousel updates correctly), but it gets added at the bottom which confused me a bit since I have a lot of maps installed. |
…s.osu doesn't get imported on Undelete. Also moved the const property to BeatmapManager.
Fixed that oversight. The beatmap hash for the "menu music"'s beatmap is now inside |
Can't you just check the |
…e undeleting) to "Protected" field.
As this is a non-instant operation, I think a progress notification should be added similar to the other tasks associated with these buttons. |
It would be nice to have #1707 merged (or closed, for that matter) before this so I can add a custom CompletionText without re-PRing. |
#1707 has been merged now – wanna update this to take advantage of it? |
@FreezyLemon make sure to pay attention to that change I made. quite important from a performance perspective (every |
Closes #1215.
This now works reliably after the problem mentioned in that issue has been fixed.
However the
BeatmapCarousel
will not update when the button is clicked while having SongSelect open, though this should be fixed by #1657 .