New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make completion notification text for ProgressNotifications customisable #1707

Merged
merged 5 commits into from Dec 20, 2017

Conversation

3 participants
@FreezyLemon
Member

FreezyLemon commented Dec 18, 2017

It's just a small QoL improvement over having multiple notifications showing "Task is completed!". Especially when downloading maps, this is nice to have (imo).

@peppy

please test changes, not make them blindly

FreezyLemon and others added some commits Dec 19, 2017

has been resolved

@peppy

peppy approved these changes Dec 19, 2017

@peppy peppy changed the title from Add customizable "Completion text" to ProgressNotifications to Make completion notification text for ProgressNotifications customisable Dec 20, 2017

@peppy peppy merged commit cee39af into ppy:master Dec 20, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@FreezyLemon FreezyLemon deleted the FreezyLemon:customize-progress-notification branch Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment