Make completion notification text for ProgressNotifications customisable #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
previously requested changes
Dec 19, 2017
osu.Game/Beatmaps/BeatmapManager.cs
Outdated
| { | ||
| CompletionText = $"Installed {beatmapSetInfo.Metadata.Artist} - {beatmapSetInfo.Metadata.Title}!", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
reviewed
Dec 19, 2017
| notification = new UpdateProgressNotification { State = ProgressNotificationState.Active }; | ||
| notification = new UpdateProgressNotification | ||
| { | ||
| CompletionText = "Successfully updated the game!", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
requested changes
Dec 19, 2017
peppy
approved these changes
Dec 19, 2017
peppy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just a small QoL improvement over having multiple notifications showing "Task is completed!". Especially when downloading maps, this is nice to have (imo).