Add ShortName to RulesetInfo #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
requested changes
Dec 11, 2017
osu.Game/Rulesets/Ruleset.cs
Outdated
| .Where(mod => mod != null) | ||
| // Filter out all null mods | ||
| .SelectMany(mod => (mod as MultiMod)?.Mods ?? new[] { mod }); | ||
| // Resolve MultiMods as their .Mods property |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -93,6 +93,8 @@ public override IEnumerable<Mod> GetModsFor(ModType type) | |||
|
|
|||
| public override string Description => "osu!catch"; | |||
|
|
|||
| public override string ShortName => "fruits"; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smoogipoo
previously requested changes
Dec 11, 2017
osu.Game/osu.Game.csproj
Outdated
| @@ -285,6 +285,10 @@ | |||
| <Compile Include="Migrations\20171119065731_AddBeatmapOnlineIDUniqueConstraint.Designer.cs"> | |||
| <DependentUpon>20171119065731_AddBeatmapOnlineIDUniqueConstraint.cs</DependentUpon> | |||
| </Compile> | |||
| <Compile Include="Migrations\20171209034410_AddRulesetInfoShortName.cs" /> | |||
| <Compile Include="Migrations\20171209034410_AddRulesetInfoShortName.designer.cs"> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smoogipoo
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have decided that when communicating with the API - and in general referring to rulesets - it should be done so using a ShortName, or acronym, rather than ID.
This adds the ShortName field to the client-side database.