Fix personal best score showing delete option on context menu #18993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests need attention, but also would it still show up if you've downloaded the replay locally? Or are these scores completely online with |
|
It won't. The personal best score is only displayed on online leaderboards and thus has no files, correct. Will there be a download state for leaderboard scores in the future? It'll make sense to have the delete option when it's downloaded locally (while in an online leaderboard), but you don't know until you go to the results screen and local leaderboards. |
smoogipoo
approved these changes
Jul 5, 2022
|
I think this is okay for now, until the file assertion no longer holds. |
peppy
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this: