Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework sliders in osu! flashlight difficulty calculation #24124

Closed
wants to merge 5 commits into from

Conversation

molneya
Copy link
Contributor

@molneya molneya commented Jul 5, 2023

This changes some things with sliders:

  • Considers heads of sliders in jumpDistance.
  • Uses slider velocity as a scale to determine how hard a slider is to read.
    • This nerfs some sliders, but mostly buffs long and fast sliders.
  • Apply hidden bonus to sliders.

Change examples:

This change also fixes a silly bug where spinners' StrainTime was not being accounted for correctly.

Example:

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 23, 2023
@molneya molneya marked this pull request as draft September 25, 2023 14:04
@molneya
Copy link
Contributor Author

molneya commented Nov 11, 2023

Closing since there hasn't really been any movement in the pp scene for a while, and I've got a new branch with more changes that I'm working on instead.

@molneya molneya closed this Nov 11, 2023
@molneya molneya deleted the fl-slider-rework2 branch May 12, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants