Update Accuracy PP to take into account slider judgements if they are present #25722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That may not be the case anymore very soon. See #25594. I think this change is premature until we finalise slider mechanics. As such, I think it is best for this PR to be closed at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accuracy PP in osu! has a length bonus based off of the number of hitcircles, because maintaining accuracy for longer periods is more difficult. This is only based off of hitcircle count, because in stable slider judgements are more lenient. However, lazer slider judgements are the same hitcircle judgements, so it makes no sense to exclude them from accuracy length bonus.