Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting Hash and Online IDs on beatmap import #2673

Merged
merged 5 commits into from May 31, 2018

Conversation

@peppy
Copy link
Member

@peppy peppy commented May 29, 2018

Removes unique constraints and manually handles collisions on import.

peppy added 4 commits May 29, 2018
We are going to allow multiple instances of the same beatmap info hash as they could be in different beatmap sets.
…conflicts

# Conflicts:
#	osu.Game/Database/ArchiveModelManager.cs
Copy link
Contributor

@smoogipoo smoogipoo left a comment

lgtm

@smoogipoo smoogipoo merged commit c1d5956 into ppy:master May 31, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy deleted the peppy:fix-beatmap-import-conflicts branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants