Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting Hash and Online IDs on beatmap import #2673

Merged
merged 5 commits into from May 31, 2018

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented May 29, 2018

Removes unique constraints and manually handles collisions on import.

@peppy peppy added realm deals with local realm database resolves issue labels May 29, 2018
…conflicts

# Conflicts:
#	osu.Game/Database/ArchiveModelManager.cs
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoogipoo smoogipoo merged commit c1d5956 into ppy:master May 31, 2018
@peppy peppy deleted the fix-beatmap-import-conflicts branch June 21, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
realm deals with local realm database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants