Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Traceable performance calculation support #27148

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

Givikap120
Copy link
Contributor

Traceable is a very interesting alternative to Hidden, so I think it's deserves to have pp award.
Also I think it should be moved to DifficultyIncrease category, but it's an another topic.

@stanriders stanriders requested a review from a team February 12, 2024 19:12
Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of how completely arbitrary multipliers were chosen here - I don't think there's nearly enough data to see how TC affects difficulty right now

osu.Game.Rulesets.Osu/Mods/OsuModTraceable.cs Outdated Show resolved Hide resolved
@bdach bdach requested a review from a team February 13, 2024 07:04
Copy link
Contributor

@apollo-dw apollo-dw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traceable and hidden are along a very similar wavelength, so I'm OK with treating them the same until we have more data to play with for balancing

Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with TC being the same as HD for now

Copy link
Member

@tsunyoku tsunyoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for now, lets get more data to change this in the future though

@smoogipoo
Copy link
Contributor

smoogipoo commented Apr 13, 2024

I saw a review was requested of me, my current status on this is I'd like to add mod-specific generation to diffcalc-sheet-generator first. There's like... 8 scores (lol) in the dumps, that might be interesting to know about.

Will look into it over this weekend.

@smoogipoo
Copy link
Contributor

Let's see how this goes...

!diffcalc
OSU_B=https://github.com/smoogipoo/osu/tree/traceable_pp-tmp
MOD_FILTERS="+TC"

@Givikap120
Copy link
Contributor Author

@smoogipoo
Copy link
Contributor

smoogipoo commented Apr 15, 2024

@smoogipoo
Copy link
Contributor

!diffcalc
OSU_B=https://github.com/smoogipoo/osu/tree/traceable_pp-tmp
MOD_FILTERS="+TC"

@smoogipoo
Copy link
Contributor

Well, the spreadsheet's empty but I think that's just because it's using top 1000 data. I ran it locally with what I think was the top 10000 data instead: https://docs.google.com/spreadsheets/d/15w_m7iCydC9iQr2wP4rw8oZTKFsKt8yuaqaIy6mf9Do/edit#gid=869359753

It's something I guess ¯\(ツ)

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that merging this PR will not make this mod ranked.

@smoogipoo smoogipoo merged commit 0e218ee into ppy:master Apr 15, 2024
13 of 17 checks passed
@Givikap120 Givikap120 deleted the traceable_pp branch September 22, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Deployed
Development

Successfully merging this pull request may close these issues.

6 participants