Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if Windows compatibility mode flags are detected on startup #27654

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Commits on Mar 17, 2024

  1. Configuration menu
    Copy the full SHA
    8599f3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b7a790 View commit details
    Browse the repository at this point in the history
  3. Remove comments about compatibility mode from Program.cs since this…

    … PR will be resolving it
    smallketchup82 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    1f362a5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    87dcaa8 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Configuration menu
    Copy the full SHA
    be2f3f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9ee7b4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a59e63a View commit details
    Browse the repository at this point in the history
  4. Check if compatibility mode is checked for the runtime executable ins…

    …tead of checking if it is flipped on for any executable titled "osu!.exe"
    smallketchup82 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4865310 View commit details
    Browse the repository at this point in the history
  5. Code quality

    - Make checkCompatibilityMode static
    - Fixing naming for CheckCompatibilityMode
    - Use explicit type for exePath
    smallketchup82 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0a66f43 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Final touches

    - Add docstrings to the functions
    - Add a new function to log the compatibility flags
    - Add patch for locating the actual exe
    smallketchup82 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e7d7bdc View commit details
    Browse the repository at this point in the history
  2. Move flags log within if statement clause

    In my previous commit I figured that I should put it outside of the if
    statement so that it logs the compatibility mode flags regardless (in
    case the other messagebox is shown for some reason and compatibility
    mode is enabled). But I figured that it's highly likely this would never
    happen, so might as well just keep it in the if statement.
    smallketchup82 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    5d1f3b1 View commit details
    Browse the repository at this point in the history
  3. Make the notification text for the compatibility mode checker transla…

    …table
    
    Will probably make a small PR in the future to do the same for the admin
    mode checker
    smallketchup82 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    f25e50a View commit details
    Browse the repository at this point in the history
  4. Don't log to void

    smallketchup82 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    c8e03fe View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    10c0459 View commit details
    Browse the repository at this point in the history
  6. Fix compatibility flags debug info not being written to logfiles due …

    …to uninitialized logger
    
    This makes a new function, `GetCompatibilityFlags` and includes that
    within the messagebox. This would probably be a better approach for
    diagnosing something like this in general (instead of having to flip
    through a user's debug logs, you simply view a screenshot of the
    messagebox)
    smallketchup82 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    90f46cc View commit details
    Browse the repository at this point in the history