Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove estimations where score data is available for osu! difficulty calculations #27691

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Commits on Mar 22, 2024

  1. Configuration menu
    Copy the full SHA
    941c048 View commit details
    Browse the repository at this point in the history
  2. Use actual sliderends dropped instead of estimating

    Score data for non-CL scores includes sliderends dropped, meaning no need to estimate.
    
    CL scores are still estimated.
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4db6f28 View commit details
    Browse the repository at this point in the history
  3. Revert "Make length bonus account for sliders, use proper misscount f…

    …or classic"
    
    This reverts commit 941c048.
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    3dafdc0 View commit details
    Browse the repository at this point in the history
  4. Use miss count for effective miss count

    No need to estimate misses for non-CL scores.
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    8408455 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1 from Finadoggie/miss-count-fix

    Miss count fix
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    12afa8d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    eb30b4a View commit details
    Browse the repository at this point in the history
  7. Merge pull request #2 from Finadoggie/dropped-tail-fix

    Use actual sliderends dropped instead of estimating
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c9e3c10 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b0d20e6 View commit details
    Browse the repository at this point in the history
  9. Add slider ticks and reverse arrows to effective misscount

    Very much open to discussion on if these should be weighed differently
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6fe478c View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Configuration menu
    Copy the full SHA
    4f5f0e5 View commit details
    Browse the repository at this point in the history
  2. Use sliderend data for all non-legacy scores

    As per suggestion by givikap, I was not aware that non-legacy cl scores stored this data
    Finadoggie committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    58bc184 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'estimation-removal' of https://github.com/Finadoggie/osu

    …into estimation-removal
    Finadoggie committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    c24f99e View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Cap Buzz Slider Related Misses

    After letting the comments @Flamiii left brew for a while, I realized they were very much right about the buzz slider thing. As such, I've implemented a quick and dirty untested fix that will hopefully have zero unintended side-effects :)
    
    I don't see this as a permanent or final solution yet. There's definitely some potential issues/inaccuracies that could arise with maps like Notch Hell or IOException's Black Rover, but afaik this implementation would not cause any issues that stable doesn't already have.
    Finadoggie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2dd4903 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    dd17c89 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Add bool useSliderHead

    Finadoggie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ca24601 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    77814ec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    759a826 View commit details
    Browse the repository at this point in the history
  4. Re-add bool useSliderHead

    oops
    Finadoggie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    4a7b813 View commit details
    Browse the repository at this point in the history
  5. fix code formatting

    Finadoggie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d1dcac0 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Configuration menu
    Copy the full SHA
    4fe55d4 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. merged givi's accuracy changes

    stat acc save me
    Finadoggie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1f55c14 View commit details
    Browse the repository at this point in the history
  2. Revert "merged givi's accuracy changes"

    This reverts commit 1f55c14.
    Finadoggie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6c9e906 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Configuration menu
    Copy the full SHA
    8dea601 View commit details
    Browse the repository at this point in the history