Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove estimations where score data is available for osu! difficulty calculations #27691

Merged
merged 41 commits into from
Oct 22, 2024
Merged

Remove estimations where score data is available for osu! difficulty calculations #27691

merged 41 commits into from
Oct 22, 2024
+60 −21

Commits on Mar 22, 2024

  1. Make length bonus account for sliders, use proper misscount for classic

    @Finadoggie
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    941c048 View commit details
    Browse the repository at this point in the history

  2. Use actual sliderends dropped instead of estimating 

    Score data for non-CL scores includes sliderends dropped, meaning no need to estimate.

CL scores are still estimated.
    @Finadoggie
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4db6f28 View commit details
    Browse the repository at this point in the history

  3. Revert "Make length bonus account for sliders, use proper misscount f… 

    …or classic"

This reverts commit 941c048.
    @Finadoggie
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    3dafdc0 View commit details
    Browse the repository at this point in the history

  4. Use miss count for effective miss count 

    No need to estimate misses for non-CL scores.
    @Finadoggie
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    8408455 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #1 from Finadoggie/miss-count-fix 

    Miss count fix
    @Finadoggie
    Finadoggie authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    12afa8d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'estimation-removal' into dropped-tail-fix

    @Finadoggie
    Finadoggie authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    eb30b4a View commit details
    Browse the repository at this point in the history

  7. Merge pull request #2 from Finadoggie/dropped-tail-fix 

    Use actual sliderends dropped instead of estimating
    @Finadoggie
    Finadoggie authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c9e3c10 View commit details
    Browse the repository at this point in the history

  8. Update OsuPerformanceCalculator.cs

    @Finadoggie
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b0d20e6 View commit details
    Browse the repository at this point in the history

  9. Add slider ticks and reverse arrows to effective misscount 

    Very much open to discussion on if these should be weighed differently
    @Finadoggie
    Finadoggie committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6fe478c View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Merge branch 'master' into estimation-removal

    @Finadoggie
    Finadoggie authored Mar 23, 2024
    Configuration menu
    Copy the full SHA
    4f5f0e5 View commit details
    Browse the repository at this point in the history

  2. Use sliderend data for all non-legacy scores 

    As per suggestion by givikap, I was not aware that non-legacy cl scores stored this data
    @Finadoggie
    Finadoggie committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    58bc184 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'estimation-removal' of https://github.com/Finadoggie/osu … 

    …into estimation-removal
    @Finadoggie
    Finadoggie committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    c24f99e View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Cap Buzz Slider Related Misses 

    After letting the comments @Flamiii left brew for a while, I realized they were very much right about the buzz slider thing. As such, I've implemented a quick and dirty untested fix that will hopefully have zero unintended side-effects :)

I don't see this as a permanent or final solution yet. There's definitely some potential issues/inaccuracies that could arise with maps like Notch Hell or IOException's Black Rover, but afaik this implementation would not cause any issues that stable doesn't already have.
    @Finadoggie
    Finadoggie authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2dd4903 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. removed large tick misses from effectivemisscount

    @Finadoggie
    Finadoggie committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    dd17c89 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Add bool useSliderHead

    @Finadoggie
    Finadoggie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ca24601 View commit details
    Browse the repository at this point in the history

  2. Fix getting slider head drops

    @Finadoggie
    Finadoggie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    77814ec View commit details
    Browse the repository at this point in the history

  3. Clamp estimatedSliderEndsDrop

    @Finadoggie
    Finadoggie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    759a826 View commit details
    Browse the repository at this point in the history

  4. Re-add bool useSliderHead 

    oops
    @Finadoggie
    Finadoggie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    4a7b813 View commit details
    Browse the repository at this point in the history

  5. fix code formatting

    @Finadoggie
    Finadoggie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d1dcac0 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Renamed useSliderHead to useClassicSlider (and refactored code accord… 

    …ingly)
    @Finadoggie
    Finadoggie committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    4fe55d4 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. merged givi's accuracy changes 

    stat acc save me
    @Finadoggie
    Finadoggie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1f55c14 View commit details
    Browse the repository at this point in the history

  2. Revert "merged givi's accuracy changes" 

    This reverts commit 1f55c14.
    @Finadoggie
    Finadoggie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6c9e906 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Merge branch 'master' into estimation-removal

    @Finadoggie
    Finadoggie authored May 25, 2024
    Configuration menu
    Copy the full SHA
    8dea601 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'ppy:master' into estimation-removal

    @Finadoggie
    Finadoggie authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    44c9425 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Merge branch 'ppy:master' into estimation-removal

    @Finadoggie
    Finadoggie authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    3d7f4ae View commit details
    Browse the repository at this point in the history

  2. Update to use variable usingClassicSliderAccuracy

    @Finadoggie
    Finadoggie committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    b921424 View commit details
    Browse the repository at this point in the history

  3. Convert estimateSliderEndsDropped assignment into '?:' expression 

    I would just like to say that I don't know why anyone would ever want this but github told me to do it
    @Finadoggie
    Finadoggie committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    3b517e0 View commit details
    Browse the repository at this point in the history

  4. Join variable assignments with declarations

    @Finadoggie
    Finadoggie committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    3ac6a9f View commit details
    Browse the repository at this point in the history

  5. consolidated if statements for getting effectiveMissCount and countSl… 

    …iderEndsDropped
    @Finadoggie
    Finadoggie committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    29b1697 View commit details
    Browse the repository at this point in the history

  6. only assign countLargeTickMiss for slider accuracy scores 

    helps indicate it should only be used for slider acc scores
    @Finadoggie
    Finadoggie committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    88af578 View commit details
    Browse the repository at this point in the history

  7. remove score debugging code I accidentally left in

    @Finadoggie
    Finadoggie committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    5192599 View commit details
    Browse the repository at this point in the history

  8. Revert "remove score debugging code I accidentally left in" 

    This reverts commit 5192599.
    @Finadoggie
    Finadoggie committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    6bcfed8 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. use LargeTickHit instead of LargeTickMiss 

    LargeTickMiss appears to not be stored
    @Finadoggie
    Finadoggie committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1337b7e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Revert "use LargeTickHit instead of LargeTickMiss" 

    This reverts commit 1337b7e.
    @Finadoggie
    Finadoggie committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    6d4cb60 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. add large tick misses back into effectivemisscount

    @Finadoggie
    Finadoggie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    31e0853 View commit details
    Browse the repository at this point in the history

  2. merge effectivemisscount functions 

    having two functions was unnecessary
    @Finadoggie
    Finadoggie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e31e10d View commit details
    Browse the repository at this point in the history

  3. Addressed code quality concerns

    @Finadoggie
    Finadoggie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3778246 View commit details
    Browse the repository at this point in the history

  4. Only clamp estimated miss count with relevant statistics

    @Finadoggie
    Finadoggie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5907c2a View commit details
    Browse the repository at this point in the history

  5. Fix variables being used before being assigned 

    slightly miffed by the lack of build errors but oh well
    @Finadoggie
    Finadoggie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    98800fe View commit details
    Browse the repository at this point in the history

  6. Refactor and add comments

    @stanriders
    stanriders committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bcb9970 View commit details
    Browse the repository at this point in the history

  7. Fix effectiveMissCount being calculated wrong

    @stanriders
    stanriders committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    acf282d View commit details
    Browse the repository at this point in the history