Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use title as tiebreaker when sorting beatmap carousel by artist #27692

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Mar 22, 2024

Closes #27548.

Reference: https://github.com/peppy/osu-stable-reference/blob/e53980dd76857ee899f66ce519ba1597e7874f28/osu!/GameplayElements/Beatmaps/BeatmapTreeManager.cs#L341-L347

Curious of thoughts on the goto case usage. It's the first one across game and framework, but I think it works well for what it is and alternatives are worse off?

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine

@smoogipoo smoogipoo merged commit 77660e5 into ppy:master Mar 22, 2024
17 checks passed
@bdach bdach deleted the artist-sort-uses-title-as-tiebreaker branch March 22, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When sorting beatmaps by artist, beatmaps with same artist are not sorted by title
2 participants