Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double binding causing game crash after API enters failing state #27754

Merged
merged 3 commits into from
Mar 29, 2024

Fix bindable not being correctly re-bound across local user changes

d9cf5b5
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix double binding causing game crash after API enters failing state #27754

Fix bindable not being correctly re-bound across local user changes
d9cf5b5
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Mar 29, 2024 in 1s

5725 passed, 1 failed and 52 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

5778 tests were completed in 1492s with 5725 passed, 1 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation 44✅ 1❌ 70s

❌ osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation

✅ TestAttemptPlayBeatmapMissingFails
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapOptionsInput
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConstructor
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestExitGameFromSongSelect
✅ TestExitImmediatelyAfterCompletion
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithEscape
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithEscape
✅ TestExitWithHoldDisabled
✅ TestExitWithOperationInProgress
✅ TestFeaturedArtistDisclaimerDialog
✅ TestForceExitWithOperationInProgress
✅ TestMainOverlaysClosesNotificationOverlay
✅ TestMainOverlaysClosesSettingsOverlay
✅ TestMenuMakesMusic
✅ TestModSelectInput
✅ TestModsResetOnEnteringMultiplayer
✅ TestOpenModSelectOverlayUsingAction
✅ TestOpenOptionsAndExitWithEscape
✅ TestOverlayClosing
✅ TestPresentBeatmapAfterDeletion
✅ TestPushMatchSubScreenAndPressBackButtonImmediately
✅ TestPushSongSelectAndPressBackButtonImmediately
✅ TestQuickSkinEditorDoesntNukeSkin
✅ TestRetryCountIncrements
✅ TestRetryFromResults
✅ TestRetryImmediatelyAfterCompletion
✅ TestSettingsViaHotkeyFromMainMenu
✅ TestShowMedalAtResults
✅ TestSongContinuesAfterExitPlayer(False)
✅ TestSongContinuesAfterExitPlayer(True)
✅ TestSongSelectBackActionHandling
✅ TestSongSelectScrollHandling
✅ TestToolbarHiddenByUser
❌ TestTouchScreenDetectionAtSongSelect
	TearDown : System.TimeoutException : "wait for song select" timed out
✅ TestTouchScreenDetectionInGame
✅ TestWaitForNextTrackInMenu

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation ► TestTouchScreenDetectionAtSongSelect

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "wait for song select" timed out
Raw output
TearDown : System.TimeoutException : "wait for song select" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
   at InvokeStub_TestScene.RunTestsFromNUnit(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)