Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double binding causing game crash after API enters failing state #27754

Merged
merged 3 commits into from
Mar 29, 2024

Fix bindable not being correctly re-bound across local user changes

d9cf5b5
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix double binding causing game crash after API enters failing state #27754

Fix bindable not being correctly re-bound across local user changes
d9cf5b5
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, SingleThread) failed Mar 29, 2024 in 1s

5723 passed, 3 failed and 52 skipped

Tests failed

❌ TestResults-macOS-SingleThread.trx

5778 tests were completed in 2373s with 5723 passed, 3 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight 13✅ 1❌ 22s
osu.Game.Rulesets.Osu.Tests.TestSceneStartTimeOrderedHitPolicy 9✅ 1❌ 32s
osu.Game.Tests.Visual.Editing.TestSceneEditorTestGameplay 5✅ 1❌ 27s

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight

✅ TestComboBasedSize(False)
✅ TestComboBasedSize(True)
✅ TestConstructor
✅ TestFollowDelay(120)
✅ TestFollowDelay(1200)
✅ TestFollowDelay(600)
✅ TestPlayfieldBasedSize
✅ TestSizeMultiplier(0.5f)
✅ TestSizeMultiplier(1.0f)
✅ TestSizeMultiplier(1.5f)
✅ TestSizeMultiplier(2.0f)
✅ TestSliderDimsOnlyAfterStartTime
❌ TestSliderDoesDimAfterStartTimeIfHitEarly
	TearDown : System.TimeoutException : "test passed" timed out
✅ TestSliderDoesDimAfterStartTimeIfHitLate

❌ osu.Game.Rulesets.Osu.Tests.TestSceneStartTimeOrderedHitPolicy

✅ TestClickSecondCircleAfterFirstCircleTime
✅ TestClickSecondCircleAtFirstCircleTime
✅ TestClickSecondCircleBeforeFirstCircleTime
❌ TestClickSecondCircleBeforeFirstCircleTimeWithFirstCircleJudged
	TearDown : System.TimeoutException : "Wait until player is loaded" timed out
✅ TestConstructor
✅ TestHitCircleBeforeSpinner
✅ TestHitSliderHeadBeforeHitCircle
✅ TestHitSliderTicksBeforeCircle
✅ TestInputFallsThroughJudgedSliders
✅ TestMissSliderHeadAndHitAllSliderTicks

❌ osu.Game.Tests.Visual.Editing.TestSceneEditorTestGameplay

✅ TestBasicGameplayTest
✅ TestCancelGameplayTestWithUnsavedChanges
✅ TestClockTimeTransferIsOneDirectional
✅ TestConstructor
✅ TestGameplayTestWhenTrackRunning
❌ TestSaveChangesBeforeGameplayTest
	TearDown : System.TimeoutException : "wait for return to editor" timed out

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, SingleThread)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight ► TestSliderDoesDimAfterStartTimeIfHitEarly

Failed test found in:
  TestResults-macOS-SingleThread.trx
Error:
  TearDown : System.TimeoutException : "test passed" timed out
Raw output
TearDown : System.TimeoutException : "test passed" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
   at InvokeStub_TestScene.RunTestsFromNUnit(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, SingleThread)

osu.Game.Rulesets.Osu.Tests.TestSceneStartTimeOrderedHitPolicy ► TestClickSecondCircleBeforeFirstCircleTimeWithFirstCircleJudged

Failed test found in:
  TestResults-macOS-SingleThread.trx
Error:
  TearDown : System.TimeoutException : "Wait until player is loaded" timed out
Raw output
TearDown : System.TimeoutException : "Wait until player is loaded" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
   at InvokeStub_TestScene.RunTestsFromNUnit(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, SingleThread)

osu.Game.Tests.Visual.Editing.TestSceneEditorTestGameplay ► TestSaveChangesBeforeGameplayTest

Failed test found in:
  TestResults-macOS-SingleThread.trx
Error:
  TearDown : System.TimeoutException : "wait for return to editor" timed out
Raw output
TearDown : System.TimeoutException : "wait for return to editor" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
   at InvokeStub_TestScene.RunTestsFromNUnit(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)