Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pp Refactoring: Removing DEFAULT_DIFFICULTY_MULTIPLIER from OsuStrainSkill #29291

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Pp Refactoring: Removing DEFAULT_DIFFICULTY_MULTIPLIER from OsuStrainSkill #29291

merged 4 commits into from
Sep 13, 2024

Conversation

Givikap120
Copy link
Contributor

  • Removed DEFAULT_DIFFICULTY_MULTIPLIER and DifficultyMultiplier from OsuStrainSkill because it serves no practical purpose.
  • Values from there moved to skillMultiplier, where those number should've been

@smoogipoo
Copy link
Contributor

!diffcalc

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Target: #29291
Spreadsheet: https://docs.google.com/spreadsheets/d/1tIoy0rmz4EiSlHdediXtTA_k4L3KCtRm8ATrjiKFr4E/edit

@smoogipoo smoogipoo merged commit 6f14309 into ppy:master Sep 13, 2024
13 checks passed
@Givikap120 Givikap120 deleted the pp_refactoring_osustrainskill branch September 22, 2024 12:20
@bdach bdach mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:difficulty size/S
Projects
Difficulty calculation changes
Status: Deployed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Givikap120 @smoogipoo