Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate lazer in windows menus #29822

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

smallketchup82
Copy link
Contributor

@smallketchup82 smallketchup82 commented Sep 9, 2024

Windows has a really unorthodox way of generating human readable names for exe's. To put it simply, it reads the Description attribute of the .exe file. This also is not documented anywhere except for a really obscure reference.

Lazer, prior to this PR, would default to setting the Description of the exe to "osu!". This PR changes it so that the exe's Description is osu!lazer. This helps to differentiate between osu!lazer and osu!stable, because nobody wants to deal with this
image

Here's how it'll look with this PR
CleanShot 2024-09-09 at 12 47 33@2x

Tested and confirmed to work on Windows 11 23h2

@peppy
Copy link
Sponsor Member

peppy commented Sep 9, 2024

Should be osu!(lazer) to match everywhere else.

Also not confident this won't affect other random places we least expect it to.

@peppy
Copy link
Sponsor Member

peppy commented Sep 10, 2024

Let's go with this. I've checked online and can't seem to find any usage of AssemblyTitle apart from display purposes in explorer so we should be okay.

@peppy peppy merged commit 1037fbb into ppy:master Sep 10, 2024
13 checks passed
@smallketchup82 smallketchup82 deleted the differentiate-lazer-in-menus branch September 10, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants