Allow pausing gameplay via middle mouse button #9540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
previously approved these changes
Jul 12, 2020
|
In stable, the gameplay mouse buttons toggle disables this. I think lazer should do the same. Also the hold to confirm is not working right. Pressing the middle button and releasing it will not cancel it. |
bdach
previously requested changes
Jul 12, 2020
bdach
dismissed
their stale review
addressed - the mouse button toggle issue is likely out of scope here
smoogipoo
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that for the moment this just triggers standard "quit" behaviour (for cases like replays). This can change in the future once we have the ability to pause replays as well, but having the binding in place earlier is favourable IMO.