Apply manual cleanups/refactorings to OpenGL backend #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
commented
Apr 30, 2024
Comment on lines
-40
to
+44
| if (this.gd.BackendType == GraphicsBackend.OpenGLES) | ||
| if (gd.BackendType == GraphicsBackend.OpenGLES) |
There was a problem hiding this comment.
This would've caused a nullref, though we don't use compute shaders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't previously apply cleanups here because I'm not sure where the backend stands for us at this point. It's coded as a "deferred" backend so that everything is done in one loop upon
device.SubmitCommands(), but this is not a requirement for us since we only have one context.We may end up removing the deferring aspect of it, removing most of the overheads in the process.