Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logData; logError #16

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 43 additions & 2 deletions lib/src/logging_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,51 @@ class LoggingService {
}

assert(messageCallback != null);
final Object message = messageCallback();
final String message = messageCallback();
assert(message != null);

_logMessageCallback(json.encode(message), channel);
_logMessageCallback(message, channel);
}

void logData(
String channel,
Object data, {
LogMessageCallback messageCallback,
Object toEncodable(Object nonEncodable),
}) {
assert(channel != null);
if (!shouldLog(channel)) {
return;
}

String message =
messageCallback != null ? messageCallback() : data.toString();
if (toEncodable != null) {
data = toEncodable(data);
}
developer.log(message, name: channel, error: data);
}

void logError(
String channel,
Object error, {
StackTrace stackTrace,
LogMessageCallback messageCallback,
}) {
assert(channel != null);
if (!shouldLog(channel)) {
return;
}

String message =
messageCallback != null ? messageCallback() : error.toString();
developer.log(
message,
name: channel,
level: 1000,
error: error,
stackTrace: stackTrace,
);
}

void registerChannel(String name, {String description}) {
Expand Down
28 changes: 27 additions & 1 deletion lib/src/logs.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import 'package:logs/src/logging_service.dart';

/// A callback that, when evaluated, returns a log message. Log messages must
/// be encodable as JSON using `json.encode()`.
typedef LogMessageCallback = Object Function();
typedef LogMessageCallback = String Function();

/// Enable (or disable) logging for all events on the given [channel].
void enableLogging(String channel, [bool enable = true]) {
Expand Down Expand Up @@ -64,4 +64,30 @@ class Log {
void log(LogMessageCallback messageCallback) {
loggingService.log(channel, messageCallback);
}

void logData(
Object data, {
LogMessageCallback messageCallback,
Object toEncodable(Object nonEncodable),
}) {
loggingService.logData(
channel,
data,
messageCallback: messageCallback,
toEncodable: toEncodable,
);
}

void logError(
Object error, {
StackTrace stackTrace,
LogMessageCallback messageCallback,
}) {
loggingService.logError(
channel,
error,
messageCallback: messageCallback,
stackTrace: stackTrace,
);
}
}