Fix issues on websites with strict CSP #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing `element.setAttribute('style', styles);` with `element.style.cssText = styles;` to allow Filepond usage on website with strict CSP.
Replacing `element.setAttribute('style', styles);` with `element.style.cssText = styles;` to allow usage of Filepond on websites with strict CSP.
Replacing `element.setAttribute('style', styles);` with `element.style.cssText = styles;` to allow usage of Filepond on websites with strict CSP.
Replacing `element.setAttribute('style', styles);` with `element.style.cssText = styles;` to allow usage of Filepond on websites with strict CSP.
Replacing `element.setAttribute('style', styles);` with `element.style.cssText = styles;` to allow usage of Filepond on websites with strict CSP.
|
Thanks, I'm looking into this now. |
|
I've set up a test comparing |
|
Yea, I see I did a goof there. I will close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
element.setAttribute('style', styles);withelement.style.cssText = styles;allows the styles to be loaded without errors on websites with strict Content-Security-Policy. It has been tested on Chrome 77, Firefox 65, Microsoft Edge 42.17134 and Internet Explorer 11. Also this actually allows the widget to load a lot faster according to performance tab in Chrome's dev console (CPU was set to 4x slowdown). Instead of taking ~300ms to load it takes ~68ms (at least on my work laptop).