Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

add the ability for a direct image response #10

Merged
merged 2 commits into from
Sep 21, 2020
Merged

add the ability for a direct image response #10

merged 2 commits into from
Sep 21, 2020

Conversation

pqt
Copy link
Collaborator

@pqt pqt commented Sep 21, 2020

This is a small addition to the internal API that adds a /image suffix to convert the response to directly be the generated image.

This means you could technically use the API directly to generate the images (though there's zero caching layer right now so this should be expected to be repetitiously slow).

Example

https://social-preview-git-image.pqt.vercel.app/api/github/pqt/social-preview/image

@vercel
Copy link

vercel bot commented Sep 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pqt/social-preview/rf4v4jypj
✅ Preview: https://social-preview-git-image.pqt.vercel.app

@pqt
Copy link
Collaborator Author

pqt commented Sep 21, 2020

📝Changed routes:

/
Screenshot of /
(view full size)

And 1 other route:

Commit d933183 (https://social-preview-git-image.pqt.now.sh).

@pqt pqt changed the title add the ability for an image directly in the response add the ability for a direct image response Sep 21, 2020
@pqt pqt merged commit 4c460f1 into main Sep 21, 2020
@pqt pqt deleted the image branch September 21, 2020 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant