Fix URL query encoding #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquerna
approved these changes
Dec 13, 2022
|
@pquerna Thank you for the quick review! Are you planning on releasing a new version soon by any chance? |
Closed
|
@kszafran thanks for the PR -- yes, i've tagged v1.4.0 for this. |
S-code652
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #68. I have also encountered
+signs instead of spaces in Google Authenticator when using https://github.com/ory/kratos (which uses this library).It seems to me that copy-pasting the URL-encoding function is the simplest and most robust solution here (instead of trying to do some clever replacing post-encoding). I also fixed some typos in the first commit.