Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image styles - alignments + dimension(pixel/pt only) #29

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Image styles - alignments + dimension(pixel/pt only) #29

wants to merge 6 commits into from

Conversation

maifeeulasad
Copy link

added style for image

    For right-alignment: `'float: right;'`
    For center-alignment: `'display: block; margin-left: auto; margin-right: auto;'`
    Everything else would be Left aligned

All tests passed, and the output looks fine, like:
mr4
mr1
mr2
mr3

@maifeeulasad maifeeulasad changed the title Image styles more like alignment Image styles - more like alignments Dec 23, 2021
@maifeeulasad maifeeulasad changed the title Image styles - more like alignments Image styles - alignments + dimension(pixel/pt only) Dec 23, 2021
@maifeeulasad
Copy link
Author

Looks something like this:
mr8
mr5
mr6
mr7

pqzx
pqzx reviewed Mar 8, 2022
View reviewed changes
htmldocx/h2d.py Outdated Show resolved Hide resolved
@pqzx
Copy link
Owner

pqzx commented Mar 8, 2022

Thanks for the PR @maifeeulasad , this looks good. Minor comment.

@maifeeulasad
Copy link
Author

@pqzx really appreciate it. Let me know if anything else is required. Thanks.

pqzx
pqzx requested changes Mar 8, 2022
View reviewed changes
Copy link
Owner

@pqzx pqzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more instances

htmldocx/h2d.py Outdated Show resolved Hide resolved
htmldocx/h2d.py Outdated Show resolved Hide resolved
htmldocx/h2d.py Outdated Show resolved Hide resolved
@maifeeulasad
Copy link
Author

@pqzx fixed all linting issues at bd6cc8f

@maifeeulasad maifeeulasad requested a review from pqzx March 9, 2022 15:25
@maifeeulasad
Copy link
Author

Hello @pqzx, any update regarding this?

Does it require any additional change? Please let me know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pqzx pqzx Awaiting requested review from pqzx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maifeeulasad @pqzx