Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove find_package(gazebo), to solve -pthread linking errors #139

Merged
merged 1 commit into from
Mar 18, 2018
Merged

remove find_package(gazebo), to solve -pthread linking errors #139

merged 1 commit into from
Mar 18, 2018

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Mar 16, 2018

Closes #138

@k-okada k-okada changed the title remove find_package(gazebo), to solvle -pthread linking errors remove find_package(gazebo), to solve -pthread linking errors Mar 16, 2018
@k-okada k-okada mentioned this pull request Mar 16, 2018
Closed
v4hn
v4hn approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package does not build c++ code and doesn't export headers. So this find_package didn't make sense in the first place...

@k-okada k-okada merged commit 8a6401e into PR2:kinetic-devel Mar 18, 2018
@k-okada k-okada deleted the fix_138 branch March 18, 2018 09:04
@k-okada
Copy link
Contributor Author

k-okada commented Mar 18, 2018

@v4hn thanks,
@pazeshun please wait for new release -> ros/rosdistro#17162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v4hn v4hn v4hn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-okada @v4hn