Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/node stats #8

Merged
merged 3 commits into from
May 6, 2016
Merged

Conversation

cgunning
Copy link
Contributor

@cgunning cgunning commented May 6, 2016

Adds stats for node. I had to change interval in LBNodeFQDN from int to string. Could it be a version issue and that they've changed this?

@cgunning
Copy link
Contributor Author

cgunning commented May 6, 2016

Ok. I've failed somewhat with my branches and pull requests. Sorry about that

@pr8kerl
Copy link
Owner

pr8kerl commented May 6, 2016

@cgunning Don't mind the pull requests - I appreciate the help/effort and extra features. Thanks! My F5 certainly has interval in Node FQDN as an int. I have version BIG-IP 11.6.0 Build 5.0.429 Hotfix HF5.
I'll see if mine breaks now.

@pr8kerl pr8kerl merged commit d96589f into pr8kerl:master May 6, 2016
@pr8kerl
Copy link
Owner

pr8kerl commented May 6, 2016

@cgunning yep - that node FQDN does break now

2016/05/07 08:26:05 json: cannot unmarshal number into Go value of type string

I'd be interested to know what version of BIG-IP you are running.
Tx.

@cgunning
Copy link
Contributor Author

cgunning commented May 7, 2016

Ok. That's unfortunate. I'm running version 12.0 so it seems to have been a change there which seems like a bad change to me. For best compability I think it's necessary to take the version into account. I don't know the best way to do this but I'd be happy to cooperate with you to solve this issue

@pr8kerl
Copy link
Owner

pr8kerl commented May 7, 2016

Yep - it is unfortunate. It feels like an error with the v12 software - surely it should be an int??
So for now I have set that field to an interface. Not nice. If you have a better idea - feel free to suggest.
I've raised an issue as a reminder for myself. I may ask F5 when we upgrade ours.
#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants