Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amit/create poll model #6

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Amit/create poll model #6

merged 1 commit into from
Jun 10, 2020

Conversation

amit7sri
Copy link
Collaborator

@amit7sri amit7sri commented Jun 9, 2020

fetch textfield value
added model class

first commit, needs iteration

pending- 1> populating model class

@@ -108,6 +126,9 @@ class _OptionsList extends State<OptionsList> {
child: Column(
children: <Widget>[
TextFormField(
onChanged: (value) {
print('Value for field option as "$value"' + value);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't you printing value twice? $value would print the value right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -80,10 +90,18 @@ class _CreatePollState extends State<CreatePoll> {

Widget textFormField() {
return TextFormField(
controller: _textEditingController,
//controller: _textEditingController,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commented out code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using onchanged callback, instead of controller

added model class, fetch text field value -> initial commit, need iteration

review comments fix
@prabhat00155 prabhat00155 merged commit 7af0874 into master Jun 10, 2020
@amit7sri amit7sri deleted the amit/create_poll_model branch June 12, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants