This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Added remove photos from album feature #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhuomkar
reviewed
Dec 8, 2021
Comment on lines
21
to
22
| const { imageList } = useContext(CreateAlbumContext); | ||
| const { removeImageList } = useContext(RemoveAlbumPhotosContext); |
There was a problem hiding this comment.
Can we somehow merge the states and export single provider called AlbumsProvider -> it should cater to both create and remove
Comment on lines
+38
to
44
| const AlbumPhoto = ({ | ||
| imageUrl, | ||
| imageId, | ||
| removeImageList, | ||
| setRemoveImageList, | ||
| }) => { | ||
| let history = useHistory(); |
There was a problem hiding this comment.
Do we really need this component or we can re-use similar existing one by handling props and null values?
prabhuomkar
approved these changes
Dec 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.