Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic float: Record position before debounce time #1570

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ilya-bobyr
Copy link
Contributor

It seems that we should be recording the current buffer, cursor position and change tick before we wait to see if the float should be shown or not. Otherwise, if any of the above change during the g:lsp_diagnostics_float_delay our recording would be incorrect.

@ilya-bobyr ilya-bobyr force-pushed the pr/diagnostic-float-record-cursor-before-distinct-check branch from 9946229 to 89e0a04 Compare July 23, 2024 06:21
@ilya-bobyr
Copy link
Contributor Author

ilya-bobyr commented Jul 23, 2024

This is a first commit in a sequence of 7 commits that improve the float behavior for me.
Mostly by fixing some subtle bugs.

Each commit is documented, should work, and can be reviewed independently.
I think it makes sense to look at all of them eventually.
If you prefer, I can create a single PR for all of them combined.
Or I can create new PRs one by one.
Posting the next commit only after the previous commit goes through the review process.

All the changes are in the same area, so they rely on each other quite a lot.
To some degree, some changes are justified by what comes next.
But I was trying to split them such that the future dependencies are rather weak.

It seems that we should be recording the current buffer, cursor position
and change tick before we wait to see if the float should be shown or
not.  Otherwise, if any of the above change during the
`g:lsp_diagnostics_float_delay` our recording would be incorrect.
@ilya-bobyr ilya-bobyr force-pushed the pr/diagnostic-float-record-cursor-before-distinct-check branch from 834656f to f90e0aa Compare October 23, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant