Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx 6.2.1: hash digest injection is broken due to reuse of css_files in HTML context #716

Closed
pradyunsg opened this issue Aug 31, 2023 Discussed in #708 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@pradyunsg
Copy link
Owner

Discussed in #708

Sphinx 6.2.1 reuses css_files across multiple files, which means that the injection of hash'd digests for assets fails due to the hash injection not being idempotent. This means that the build fails if there are more than one HTML files to generate.

@pradyunsg pradyunsg added the bug Something isn't working label Aug 31, 2023
@pradyunsg
Copy link
Owner Author

Until this is resolved, folks can change their requirement on Furo to: furo != 2023.08.17, != 2023.08.19. I'll yank those releases, once I have a release out with the fixes made.

@Eric-Arellano
Copy link
Contributor

I'll yank those releases, once I have a release out with the fixes made.

This will break all the Qiskit projects that are pinned to an exact Furo version. If possible, it'd be great to not yank since it's possible to use a Sphinx x Furo combination that is valid. Since there isn't a security vulnerability, I'm not sure yanking would be necessary?

@pradyunsg
Copy link
Owner Author

Yanking doesn't break pinning based workflows. See https://pypi.org/help/#yanked.

@pradyunsg
Copy link
Owner Author

@pradyunsg
Copy link
Owner Author

Screenshot 2023-09-10 at 17 03 49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants